Files
x/handler/http/connect_test.go
T
ginuerzh 23b58ddd23 refactor(handler/http): extract Authenticator, SnifferBuilder, and normalizeRequest as testable units
Extract three pure-logic components from httpHandler to eliminate I/O
coupling from auth and sniffing construction, enabling synchronous unit
tests and reducing per-request allocation in sniffAndHandle:

- Authenticator struct with AuthResult return type — auth decisions no
  longer write to the connection; callers handle response I/O. Auth
  tests drop net.Pipe/goroutines for direct return-value assertions.
- SnifferBuilder pre-built in Init and reused per-connection via Build(),
  replacing inline sniffing.Sniffer{} construction in sniffAndHandle.
- normalizeRequest extracted to util.go with NormalizedRequest type,
  collapsing 20 lines of inline URL/normalisation into a single call.
- knockMatch extracted as standalone pure function.
- clampBodySize exported as ClampBodySize for cross-package use.
- util_test.go with 22 tests covering utility functions.
- helpers_test.go consolidates shared test fakes (logger, observer, conn).
2026-05-29 00:14:44 +08:00

160 lines
3.4 KiB
Go

package http
import (
"context"
"io"
"net"
"net/http"
"testing"
"github.com/go-gost/core/handler"
xrecorder "github.com/go-gost/x/recorder"
)
func TestSniffAndHandle_NoMatch(t *testing.T) {
h := &httpHandler{
options: handler.Options{
Logger: &testLogger{},
},
}
h.md.sniffing = true
h.sniffer = &SnifferBuilder{}
client, server := net.Pipe()
defer client.Close()
defer server.Close()
go func() {
client.Write([]byte("SSH-2.0-OpenSSH\r\n"))
}()
cc, _ := net.Pipe()
defer cc.Close()
handled, err := h.sniffAndHandle(context.Background(), server, cc, &xrecorder.HandlerRecorderObject{}, &testLogger{})
if err != nil {
t.Fatal(err)
}
if handled {
t.Error("expected not handled for non-HTTP/TLS traffic")
}
}
func TestDial_NilRouter(t *testing.T) {
h := &httpHandler{
options: handler.Options{
Logger: &testLogger{},
},
}
_, err := h.dial(context.Background(), "tcp", "example.com:80")
if err == nil {
t.Error("expected error from dial with nil router")
}
}
func TestSniffAndHandle_TLS(t *testing.T) {
h := &httpHandler{
options: handler.Options{
Logger: &testLogger{},
},
}
h.md.sniffing = true
h.sniffer = &SnifferBuilder{}
client, server := net.Pipe()
defer client.Close()
defer server.Close()
// Write TLS ClientHello bytes (content type 0x16 = Handshake, followed by TLS version)
go func() {
client.Write([]byte{0x16, 0x03, 0x01, 0x00, 0x05, 0x01, 0x02, 0x03, 0x04, 0x05})
}()
cc, _ := net.Pipe()
defer cc.Close()
handled, err := h.sniffAndHandle(context.Background(), server, cc, &xrecorder.HandlerRecorderObject{}, &testLogger{})
if err != nil {
t.Logf("sniff error (expected without proper recorder): %v", err)
}
if !handled {
t.Error("expected handled for TLS traffic")
}
}
func TestHandleConnect_NilRouter(t *testing.T) {
h := &httpHandler{
options: handler.Options{
Logger: &testLogger{},
},
}
h.md.proxyAgent = defaultProxyAgent
h.md.readTimeout = 15
client, server := net.Pipe()
defer client.Close()
defer server.Close()
// Drain response to prevent Pipe blocking
go func() {
io.ReadAll(server)
}()
resp := testConnectResp()
err := h.handleConnect(context.Background(), client, &xrecorder.HandlerRecorderObject{}, &testLogger{}, "example.com:443", resp)
if err == nil {
t.Error("expected dial error with nil router")
}
}
func TestHandleConnect_SniffingEnabled(t *testing.T) {
h := &httpHandler{
options: handler.Options{
Logger: &testLogger{},
},
}
h.md.proxyAgent = defaultProxyAgent
h.md.readTimeout = 15
h.md.sniffing = true
h.sniffer = &SnifferBuilder{}
client, server := net.Pipe()
defer client.Close()
defer server.Close()
// Drain response to prevent Pipe blocking
go func() {
io.ReadAll(server)
}()
resp := testConnectResp()
err := h.handleConnect(context.Background(), client, &xrecorder.HandlerRecorderObject{}, &testLogger{}, "example.com:443", resp)
if err == nil {
t.Error("expected dial error with nil router")
}
}
func testConnectResp() *http.Response {
return &http.Response{
ProtoMajor: 1,
ProtoMinor: 1,
Header: http.Header{},
ContentLength: -1,
}
}
func TestDial_HostHash(t *testing.T) {
h := &httpHandler{
options: handler.Options{
Logger: &testLogger{},
},
}
h.md.hash = "host"
_, err := h.dial(context.Background(), "tcp", "example.com:80")
if err == nil {
t.Error("expected error from dial with nil router")
}
}