Files
x/handler/http/handler_test.go
T
ginuerzh 23b58ddd23 refactor(handler/http): extract Authenticator, SnifferBuilder, and normalizeRequest as testable units
Extract three pure-logic components from httpHandler to eliminate I/O
coupling from auth and sniffing construction, enabling synchronous unit
tests and reducing per-request allocation in sniffAndHandle:

- Authenticator struct with AuthResult return type — auth decisions no
  longer write to the connection; callers handle response I/O. Auth
  tests drop net.Pipe/goroutines for direct return-value assertions.
- SnifferBuilder pre-built in Init and reused per-connection via Build(),
  replacing inline sniffing.Sniffer{} construction in sniffAndHandle.
- normalizeRequest extracted to util.go with NormalizedRequest type,
  collapsing 20 lines of inline URL/normalisation into a single call.
- knockMatch extracted as standalone pure function.
- clampBodySize exported as ClampBodySize for cross-package use.
- util_test.go with 22 tests covering utility functions.
- helpers_test.go consolidates shared test fakes (logger, observer, conn).
2026-05-29 00:14:44 +08:00

209 lines
4.4 KiB
Go

package http
import (
"context"
"io"
"net"
"testing"
"time"
"github.com/go-gost/core/handler"
)
func TestNewHandler(t *testing.T) {
h := NewHandler()
if h == nil {
t.Fatal("NewHandler returned nil")
}
httpH, ok := h.(*httpHandler)
if !ok {
t.Fatal("NewHandler did not return *httpHandler")
}
if httpH.options.Logger != nil {
t.Error("expected nil logger")
}
}
func TestNewHandler_WithOptions(t *testing.T) {
log := &testLogger{}
h := NewHandler(
handler.LoggerOption(log),
handler.ServiceOption("test-service"),
)
httpH := h.(*httpHandler)
if httpH.options.Logger == nil {
t.Error("expected logger to be set")
}
if httpH.options.Service != "test-service" {
t.Errorf("got service %q, want %q", httpH.options.Service, "test-service")
}
}
func TestInit(t *testing.T) {
h := NewHandler(
handler.LoggerOption(&testLogger{}),
).(*httpHandler)
err := h.Init(testMD(map[string]any{}))
if err != nil {
t.Fatalf("Init returned error: %v", err)
}
if h.transport == nil {
t.Error("expected transport to be initialized")
}
if h.md.proxyAgent == "" {
t.Error("expected default proxy agent")
}
if h.md.readTimeout == 0 {
t.Error("expected default read timeout")
}
}
func TestInit_WithObserver(t *testing.T) {
h := NewHandler(
handler.LoggerOption(&testLogger{}),
handler.ObserverOption(&testObserver{}),
).(*httpHandler)
err := h.Init(testMD(map[string]any{}))
if err != nil {
t.Fatalf("Init returned error: %v", err)
}
if h.stats == nil {
t.Error("expected stats to be initialized when observer is set")
}
}
func TestInit_WithLimiter(t *testing.T) {
h := NewHandler(
handler.LoggerOption(&testLogger{}),
handler.TrafficLimiterOption(&testTrafficLimiter{}),
).(*httpHandler)
err := h.Init(testMD(map[string]any{}))
if err != nil {
t.Fatalf("Init returned error: %v", err)
}
if h.limiter == nil {
t.Error("expected limiter to be initialized")
}
}
func TestInit_WithRecorder(t *testing.T) {
h := NewHandler(
handler.LoggerOption(&testLogger{}),
).(*httpHandler)
err := h.Init(testMD(map[string]any{}))
if err != nil {
t.Fatalf("Init returned error: %v", err)
}
// recorder is nil since no matching recorder was passed
if h.recorder.Record != "" {
t.Log("recorder found even without explicit match")
}
}
func TestClose(t *testing.T) {
h := NewHandler(
handler.LoggerOption(&testLogger{}),
).(*httpHandler)
err := h.Init(testMD(map[string]any{}))
if err != nil {
t.Fatalf("Init returned error: %v", err)
}
if h.cancel == nil {
t.Fatal("expected cancel function")
}
err = h.Close()
if err != nil {
t.Errorf("Close returned error: %v", err)
}
}
func TestClose_NoInit(t *testing.T) {
h := NewHandler().(*httpHandler)
err := h.Close()
if err != nil {
t.Errorf("Close returned error: %v", err)
}
}
func TestHandle_PRIMethod(t *testing.T) {
h := NewHandler(
handler.LoggerOption(&testLogger{}),
).(*httpHandler)
if err := h.Init(testMD(map[string]any{})); err != nil {
t.Fatal(err)
}
client, server := net.Pipe()
defer client.Close()
defer server.Close()
go func() {
// Write an HTTP/2 connection preface which parses as a PRI request
client.Write([]byte("PRI * HTTP/2.0\r\nHost: example.com\r\n\r\n"))
// Drain any response so Pipe doesn't block
io.ReadAll(client)
}()
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
defer cancel()
err := h.Handle(ctx, server)
if err != nil {
t.Logf("Handle returned: %v", err)
}
}
func TestHandle_InvalidHost(t *testing.T) {
h := NewHandler(
handler.LoggerOption(&testLogger{}),
).(*httpHandler)
if err := h.Init(testMD(map[string]any{})); err != nil {
t.Fatal(err)
}
client, server := net.Pipe()
defer client.Close()
defer server.Close()
go func() {
// Invalid host that fails DNS name and IP parsing
client.Write([]byte("GET / HTTP/1.1\r\nHost: !!!invalid!!!\r\n\r\n"))
// Drain any response so Pipe doesn't block
io.ReadAll(client)
}()
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
defer cancel()
err := h.Handle(ctx, server)
if err != nil {
t.Logf("Handle returned: %v", err)
}
}
func TestSetupTrafficLimiter_NoObserver(t *testing.T) {
h := &httpHandler{
options: handler.Options{
Logger: &testLogger{},
Service: "test",
},
}
client, _ := net.Pipe()
defer client.Close()
result, done := h.setupTrafficLimiter(client, "test-client", "tcp", "example.com:80")
_ = done
if result == nil {
t.Error("expected non-nil connection")
}
}