fix(observer): add nil guards, fix resource leak, silent event drops, and missing doc comments
- WrapUDPConn, WrapPacketConn, WrapListener: add nil guards for pc/ln params - NewGRPCPlugin: return no-op observer instead of nil on connection error - gRPC plugin: fix resource leak by wiring Close() through observerWrapper and service.Close() lifecycle - Both plugins: log unknown event types instead of silently dropping them - httpPlugin: remove dead nil check for always-non-nil client field - Stats.Reset: update core interface doc to match implementation behavior - Add doc comments to all exported symbols across the observer package
This commit is contained in:
@@ -26,6 +26,10 @@ type conn struct {
|
||||
mu sync.Mutex
|
||||
}
|
||||
|
||||
// WrapConn wraps a net.Conn to track connection and traffic statistics.
|
||||
// It increments total and current connection counts, and tracks bytes
|
||||
// read and written. On Close, it decrements the current connection count.
|
||||
// If c or pStats is nil, the original conn is returned unchanged.
|
||||
func WrapConn(c net.Conn, pStats stats.Stats) net.Conn {
|
||||
if c == nil || pStats == nil {
|
||||
return c
|
||||
@@ -103,8 +107,10 @@ type packetConn struct {
|
||||
stats stats.Stats
|
||||
}
|
||||
|
||||
// WrapPacketConn wraps a net.PacketConn to track input and output bytes.
|
||||
// If pc or stats is nil, the original conn is returned unchanged.
|
||||
func WrapPacketConn(pc net.PacketConn, stats stats.Stats) net.PacketConn {
|
||||
if stats == nil {
|
||||
if pc == nil || stats == nil {
|
||||
return pc
|
||||
}
|
||||
return &packetConn{
|
||||
@@ -137,7 +143,14 @@ type udpConn struct {
|
||||
stats stats.Stats
|
||||
}
|
||||
|
||||
// WrapUDPConn wraps a net.PacketConn as a udp.Conn to track input and output
|
||||
// bytes across all read/write methods (Read, Write, ReadFrom, WriteTo,
|
||||
// ReadFromUDP, ReadMsgUDP, WriteToUDP, WriteMsgUDP). If pc or stats is nil,
|
||||
// it returns nil.
|
||||
func WrapUDPConn(pc net.PacketConn, stats stats.Stats) udp.Conn {
|
||||
if pc == nil || stats == nil {
|
||||
return nil
|
||||
}
|
||||
return &udpConn{
|
||||
PacketConn: pc,
|
||||
stats: stats,
|
||||
|
||||
@@ -12,6 +12,8 @@ type readWriter struct {
|
||||
stats stats.Stats
|
||||
}
|
||||
|
||||
// WrapReadWriter wraps an io.ReadWriter to track input and output bytes.
|
||||
// If rw or stats is nil, the original ReadWriter is returned unchanged.
|
||||
func WrapReadWriter(rw io.ReadWriter, stats stats.Stats) io.ReadWriter {
|
||||
if rw == nil || stats == nil {
|
||||
return rw
|
||||
|
||||
@@ -11,8 +11,11 @@ type listener struct {
|
||||
net.Listener
|
||||
}
|
||||
|
||||
// WrapListener wraps a net.Listener to track connection statistics. Each
|
||||
// accepted connection is wrapped via WrapConn to count connections and bytes.
|
||||
// If ln or stats is nil, the original listener is returned unchanged.
|
||||
func WrapListener(ln net.Listener, stats stats.Stats) net.Listener {
|
||||
if stats == nil {
|
||||
if ln == nil || stats == nil {
|
||||
return ln
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user