go-gost/x
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(observer): remove dead nil checks from udpConn, add unit tests

Browse Source 
The WrapUDPConn constructor returns nil when either arg is nil, so
c.stats is always non-nil in all udpConn methods. Remove 8 redundant
nil guards that were inconsistent with packetConn (which already
skipped them).

Add 65 unit tests across plugin, stats, and wrapper packages covering
nil safety, race conditions, double-close, event marshaling, and
reset-traffic semantics. Replace magic numbers in tests with named
Kind constants.
This commit is contained in:
ginuerzh
2026-05-24 23:47:48 +08:00
parent 7c95d40e05
commit 689ba36e92
7 changed files with 1267 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
observer/stats/wrapper/conn.go
+8 -24
View File
@@ -181,9 +181,7 @@ func (c *udpConn) SetWriteBuffer(n int) error {
func (c *udpConn) Read(b []byte) (n int, err error) {
if nc, ok := c.PacketConn.(io.Reader); ok {
n, err = nc.Read(b)
if c.stats != nil {
c.stats.Add(stats.KindInputBytes, int64(n))
}
c.stats.Add(stats.KindInputBytes, int64(n))
return
}
err = errUnsupport
@@ -192,18 +190,14 @@ func (c *udpConn) Read(b []byte) (n int, err error) {
func (c *udpConn) ReadFrom(p []byte) (n int, addr net.Addr, err error) {
n, addr, err = c.PacketConn.ReadFrom(p)
if c.stats != nil {
c.stats.Add(stats.KindInputBytes, int64(n))
}
c.stats.Add(stats.KindInputBytes, int64(n))
return
}
func (c *udpConn) ReadFromUDP(b []byte) (n int, addr *net.UDPAddr, err error) {
if nc, ok := c.PacketConn.(udp.ReadUDP); ok {
n, addr, err = nc.ReadFromUDP(b)
if c.stats != nil {
c.stats.Add(stats.KindInputBytes, int64(n))
}
c.stats.Add(stats.KindInputBytes, int64(n))
return
}
err = errUnsupport
@@ -213,9 +207,7 @@ func (c *udpConn) ReadFromUDP(b []byte) (n int, addr *net.UDPAddr, err error) {
func (c *udpConn) ReadMsgUDP(b, oob []byte) (n, oobn, flags int, addr *net.UDPAddr, err error) {
if nc, ok := c.PacketConn.(udp.ReadUDP); ok {
n, oobn, flags, addr, err = nc.ReadMsgUDP(b, oob)
if c.stats != nil {
c.stats.Add(stats.KindInputBytes, int64(n))
}
c.stats.Add(stats.KindInputBytes, int64(n))
return
}
err = errUnsupport
@@ -225,9 +217,7 @@ func (c *udpConn) ReadMsgUDP(b, oob []byte) (n, oobn, flags int, addr *net.UDPAd
func (c *udpConn) Write(b []byte) (n int, err error) {
if nc, ok := c.PacketConn.(io.Writer); ok {
n, err = nc.Write(b)
if c.stats != nil {
c.stats.Add(stats.KindOutputBytes, int64(n))
}
c.stats.Add(stats.KindOutputBytes, int64(n))
return
}
err = errUnsupport
@@ -236,18 +226,14 @@ func (c *udpConn) Write(b []byte) (n int, err error) {
func (c *udpConn) WriteTo(p []byte, addr net.Addr) (n int, err error) {
n, err = c.PacketConn.WriteTo(p, addr)
if c.stats != nil {
c.stats.Add(stats.KindOutputBytes, int64(n))
}
c.stats.Add(stats.KindOutputBytes, int64(n))
return
}
func (c *udpConn) WriteToUDP(b []byte, addr *net.UDPAddr) (n int, err error) {
if nc, ok := c.PacketConn.(udp.WriteUDP); ok {
n, err = nc.WriteToUDP(b, addr)
if c.stats != nil {
c.stats.Add(stats.KindOutputBytes, int64(n))
}
c.stats.Add(stats.KindOutputBytes, int64(n))
return
}
err = errUnsupport
@@ -257,9 +243,7 @@ func (c *udpConn) WriteToUDP(b []byte, addr *net.UDPAddr) (n int, err error) {
func (c *udpConn) WriteMsgUDP(b, oob []byte, addr *net.UDPAddr) (n, oobn int, err error) {
if nc, ok := c.PacketConn.(udp.WriteUDP); ok {
n, oobn, err = nc.WriteMsgUDP(b, oob, addr)
if c.stats != nil {
c.stats.Add(stats.KindOutputBytes, int64(n))
}
c.stats.Add(stats.KindOutputBytes, int64(n))
return
}
err = errUnsupport