fix(recorder): propagate context, handle short writes, add nil guards, idempotent Close, and doc comments

- httpRecorder: use http.NewRequestWithContext instead of http.NewRequest
- tcpRecorder: loop Write to avoid short-write data loss
- fileRecorder: guard against nil out in Record and Close
- plugin/grpc, plugin/http: handle json.Marshal errors instead of ignoring
- fileRecorder, redis*Recorder: idempotent Close via sync.Once
- All exported symbols: add doc comments
This commit is contained in:
ginuerzh
2026-05-24 23:58:28 +08:00
parent 689ba36e92
commit 64a16fafbc
7 changed files with 87 additions and 19 deletions
+12 -2
View File
@@ -17,20 +17,24 @@ type tcpRecorderOptions struct {
log logger.Logger
}
// TCPRecorderOption configures TCPRecorder options.
type TCPRecorderOption func(opts *tcpRecorderOptions)
// RecorderTCPRecorderOption sets the recorder name for metrics labeling.
func RecorderTCPRecorderOption(recorder string) TCPRecorderOption {
return func(opts *tcpRecorderOptions) {
opts.recorder = recorder
}
}
// TimeoutTCPRecorderOption sets the dial timeout for TCP connections.
func TimeoutTCPRecorderOption(timeout time.Duration) TCPRecorderOption {
return func(opts *tcpRecorderOptions) {
opts.timeout = timeout
}
}
// LogTCPRecorderOption sets the logger for the TCP recorder.
func LogTCPRecorderOption(log logger.Logger) TCPRecorderOption {
return func(opts *tcpRecorderOptions) {
opts.log = log
@@ -70,6 +74,12 @@ func (r *tcpRecorder) Record(ctx context.Context, b []byte, opts ...recorder.Rec
}
defer c.Close()
_, err = c.Write(b)
return err
for written := 0; written < len(b); {
n, err := c.Write(b[written:])
if err != nil {
return err
}
written += n
}
return nil
}