fix race condition for sniffing

handler/http/handler.go

@@ -681,7 +681,7 @@ func (h *httpHandler) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -700,14 +700,13 @@ func (h *httpHandler) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 			err := h.copyWebsocketFrame(cc, rw, buf, "client", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, h.recorder.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}
 
@@ -721,7 +720,7 @@ func (h *httpHandler) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -740,14 +739,13 @@ func (h *httpHandler) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 			err := h.copyWebsocketFrame(rw, cc, buf, "server", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, h.recorder.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}
 

handler/tunnel/entrypoint.go

@@ -421,7 +421,7 @@ func (ep *entrypoint) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -440,14 +440,13 @@ func (ep *entrypoint) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 			err := ep.copyWebsocketFrame(cc, rw, buf, "client", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, ep.recorder.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}
 
@@ -461,7 +460,7 @@ func (ep *entrypoint) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -480,14 +479,13 @@ func (ep *entrypoint) sniffingWebsocketFrame(ctx context.Context, rw, cc io.Read
 			err := ep.copyWebsocketFrame(rw, cc, buf, "server", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, ep.recorder.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}
 

internal/util/forwarder/sniffer.go

@@ -565,7 +565,7 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -584,14 +584,13 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 			err := h.copyWebsocketFrame(cc, rw, buf, "client", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, h.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}
 
@@ -605,7 +604,7 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -624,14 +623,13 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 			err := h.copyWebsocketFrame(rw, cc, buf, "server", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, h.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}
 

internal/util/sniffing/sniffer.go

@@ -428,7 +428,7 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -447,14 +447,13 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 			err := h.copyWebsocketFrame(cc, rw, buf, "client", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, h.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}
 
@@ -468,7 +467,7 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 	go func() {
 		ro2 := &xrecorder.HandlerRecorderObject{}
 		*ro2 = *ro
-		ro = ro2
+		ro := ro2
 
 		ticker := &time.Ticker{}
 		if d > 0 {
@@ -487,14 +486,13 @@ func (h *Sniffer) sniffingWebsocketFrame(ctx context.Context, rw, cc io.ReadWrit
 			err := h.copyWebsocketFrame(rw, cc, buf, "server", ro)
 			select {
 			case <-ticker.C:
-				if err != nil {
+				if err == nil {
-					ro.Err = err.Error()
-				}
 					ro.Duration = time.Since(start)
 					ro.Time = time.Now()
 					if err := ro.Record(ctx, h.Recorder); err != nil {
 						log.Errorf("record: %v", err)
 					}
+				}
 			default:
 			}