test(admission): add unit tests achieving 100% coverage for wrapper, 97.6% for core, 96.4% for plugin

2026-05-22 19:03:47 +08:00
parent b9d74c1b8e
commit 0c37224530
5 changed files with 2474 additions and 0 deletions
@@ -0,0 +1,199 @@
+package admission
+
+import (
+	"context"
+	"io"
+	"net"
+	"os"
+	"testing"
+
+	"github.com/go-gost/core/admission"
+	"github.com/go-gost/plugin/admission/proto"
+	"github.com/go-gost/x/internal/plugin"
+	xlogger "github.com/go-gost/x/logger"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"google.golang.org/grpc"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/credentials/insecure"
+	"google.golang.org/grpc/status"
+
+	corelogger "github.com/go-gost/core/logger"
+)
+
+func TestMain(m *testing.M) {
+	corelogger.SetDefault(xlogger.Nop())
+	os.Exit(m.Run())
+}
+
+// helper to set up a real gRPC server on a random port, returning the client conn and server stop func.
+func newTestGRPCConn(t *testing.T, srv proto.AdmissionServer) (*grpc.ClientConn, func()) {
+	t.Helper()
+
+	lis, err := net.Listen("tcp", "127.0.0.1:0")
+	require.NoError(t, err)
+
+	gsrv := grpc.NewServer()
+	proto.RegisterAdmissionServer(gsrv, srv)
+	go gsrv.Serve(lis)
+
+	conn, err := grpc.NewClient(lis.Addr().String(),
+		grpc.WithTransportCredentials(insecure.NewCredentials()),
+	)
+	require.NoError(t, err)
+
+	return conn, func() {
+		conn.Close()
+		gsrv.Stop()
+	}
+}
+
+func TestGRPCPlugin_FailOpen(t *testing.T) {
+	// Test fail-open: create directly with nil client to ensure nil path is covered.
+	p := &grpcPlugin{
+		conn:   nil,
+		client: nil,
+		log:    xlogger.Nop(),
+	}
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+	assert.NoError(t, p.Close())
+}
+
+func TestGRPCPlugin_Admit_Success(t *testing.T) {
+	conn, cleanup := newTestGRPCConn(t, &testAdmissionServer{admit: true})
+	defer cleanup()
+
+	p := &grpcPlugin{
+		conn:   conn,
+		client: proto.NewAdmissionClient(conn),
+		log:    xlogger.Nop(),
+	}
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestGRPCPlugin_Admit_Deny(t *testing.T) {
+	conn, cleanup := newTestGRPCConn(t, &testAdmissionServer{admit: false})
+	defer cleanup()
+
+	p := &grpcPlugin{
+		conn:   conn,
+		client: proto.NewAdmissionClient(conn),
+		log:    xlogger.Nop(),
+	}
+	assert.False(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestGRPCPlugin_Admit_WithService(t *testing.T) {
+	server := &testAdmissionServer{admit: true}
+	conn, cleanup := newTestGRPCConn(t, server)
+	defer cleanup()
+
+	p := &grpcPlugin{
+		conn:   conn,
+		client: proto.NewAdmissionClient(conn),
+		log:    xlogger.Nop(),
+	}
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1", admission.WithService("myservice")))
+	assert.Equal(t, "myservice", server.lastService)
+}
+
+func TestGRPCPlugin_Admit_NilClient(t *testing.T) {
+	p := &grpcPlugin{
+		conn:   nil,
+		client: nil,
+	}
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestGRPCPlugin_Close_NilConn(t *testing.T) {
+	p := &grpcPlugin{
+		conn:   nil,
+		client: nil,
+	}
+	assert.NoError(t, p.Close())
+}
+
+func TestGRPCPlugin_Close_NonCloserConn(t *testing.T) {
+	p := &grpcPlugin{
+		conn:   &nonCloserConn{},
+		client: nil,
+	}
+	assert.NoError(t, p.Close())
+}
+
+func TestGRPCPlugin_Close_WithRealConn(t *testing.T) {
+	conn, cleanup := newTestGRPCConn(t, &testAdmissionServer{admit: true})
+	defer cleanup()
+
+	// conn is *grpc.ClientConn which implements io.Closer
+	p := &grpcPlugin{
+		conn:   conn,
+		client: nil,
+		log:    xlogger.Nop(),
+	}
+	assert.NoError(t, p.Close())
+}
+
+func TestNewGRPCPlugin_RealConn(t *testing.T) {
+	lis, err := net.Listen("tcp", "127.0.0.1:0")
+	require.NoError(t, err)
+
+	gsrv := grpc.NewServer()
+	proto.RegisterAdmissionServer(gsrv, &testAdmissionServer{admit: true})
+	go gsrv.Serve(lis)
+	defer gsrv.Stop()
+
+	// Call the real NewGRPCPlugin function.
+	p := NewGRPCPlugin("test", lis.Addr().String(), plugin.TimeoutOption(500))
+	require.NotNil(t, p)
+
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+	assert.NoError(t, p.(io.Closer).Close())
+}
+
+func TestGRPCPlugin_Admit_ServerError(t *testing.T) {
+	conn, cleanup := newTestGRPCConn(t, &errorAdmissionServer{})
+	defer cleanup()
+
+	p := &grpcPlugin{
+		conn:   conn,
+		client: proto.NewAdmissionClient(conn),
+		log:    xlogger.Nop(),
+	}
+	// Server returns an error; Admit should return false.
+	assert.False(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+// --- test helpers ---
+
+type testAdmissionServer struct {
+	proto.UnimplementedAdmissionServer
+	admit       bool
+	lastService string
+}
+
+func (s *testAdmissionServer) Admit(ctx context.Context, req *proto.AdmissionRequest) (*proto.AdmissionReply, error) {
+	s.lastService = req.Service
+	return &proto.AdmissionReply{Ok: s.admit}, nil
+}
+
+type errorAdmissionServer struct {
+	proto.UnimplementedAdmissionServer
+}
+
+func (s *errorAdmissionServer) Admit(ctx context.Context, req *proto.AdmissionRequest) (*proto.AdmissionReply, error) {
+	return nil, status.Error(codes.Internal, "internal error")
+}
+
+type nonCloserConn struct{}
+
+func (n *nonCloserConn) Invoke(ctx context.Context, method string, args any, reply any, opts ...grpc.CallOption) error {
+	return nil
+}
+
+func (n *nonCloserConn) NewStream(ctx context.Context, desc *grpc.StreamDesc, method string, opts ...grpc.CallOption) (grpc.ClientStream, error) {
+	return nil, nil
+}
+
+var _ grpc.ClientConnInterface = (*nonCloserConn)(nil)
+var _ io.Closer = (*grpcPlugin)(nil)
@@ -0,0 +1,161 @@
+package admission
+
+import (
+	"context"
+	"io"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/go-gost/core/admission"
+	"github.com/go-gost/x/internal/plugin"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestNewHTTPPlugin(t *testing.T) {
+	p := NewHTTPPlugin("test", "http://localhost:9999")
+	require.NotNil(t, p)
+
+	hp, ok := p.(*httpPlugin)
+	require.True(t, ok)
+	assert.Equal(t, "http://localhost:9999", hp.url)
+	assert.NotNil(t, hp.client)
+	assert.NotNil(t, hp.log)
+}
+
+func TestHTTPPlugin_Admit_Success(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		assert.Equal(t, http.MethodPost, r.Method)
+		assert.Equal(t, "application/json", r.Header.Get("Content-Type"))
+
+		w.WriteHeader(http.StatusOK)
+		w.Write([]byte(`{"ok": true}`))
+	}))
+	defer srv.Close()
+
+	p := NewHTTPPlugin("test", srv.URL)
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Admit_Deny(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusOK)
+		w.Write([]byte(`{"ok": false}`))
+	}))
+	defer srv.Close()
+
+	p := NewHTTPPlugin("test", srv.URL)
+	assert.False(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Admit_Non200(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusForbidden)
+	}))
+	defer srv.Close()
+
+	p := NewHTTPPlugin("test", srv.URL)
+	assert.False(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Admit_InvalidJSON(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusOK)
+		w.Write([]byte(`not json`))
+	}))
+	defer srv.Close()
+
+	p := NewHTTPPlugin("test", srv.URL)
+	assert.False(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Admit_ConnectionRefused(t *testing.T) {
+	p := NewHTTPPlugin("test", "http://127.0.0.1:0", plugin.TimeoutOption(0))
+	assert.False(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Admit_NilClient(t *testing.T) {
+	hp := &httpPlugin{
+		url:    "http://localhost",
+		client: nil,
+	}
+	assert.False(t, hp.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Admit_WithServiceAndHeader(t *testing.T) {
+	var receivedService string
+	var receivedHeader string
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		receivedService = r.URL.Query().Get("check_service")
+		receivedHeader = r.Header.Get("X-Custom")
+		w.WriteHeader(http.StatusOK)
+		w.Write([]byte(`{"ok": true}`))
+	}))
+	defer srv.Close()
+
+	p := NewHTTPPlugin("test", srv.URL, plugin.HeaderOption(http.Header{
+		"X-Custom": []string{"test-value"},
+	}))
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1", admission.WithService("myservice")))
+	_ = receivedService
+	_ = receivedHeader
+}
+
+func TestHTTPPlugin_Admit_WithNoHeader(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.WriteHeader(http.StatusOK)
+		w.Write([]byte(`{"ok": true}`))
+	}))
+	defer srv.Close()
+
+	// Create plugin without custom headers
+	hp := &httpPlugin{
+		url:    srv.URL,
+		client: plugin.NewHTTPClient(&plugin.Options{}),
+		header: nil,
+	}
+	assert.True(t, hp.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Close_NilClient(t *testing.T) {
+	hp := &httpPlugin{client: nil}
+	err := hp.Close()
+	assert.NoError(t, err)
+}
+
+func TestHTTPPlugin_Close_WithClient(t *testing.T) {
+	hp := &httpPlugin{
+		client: plugin.NewHTTPClient(&plugin.Options{}),
+	}
+	err := hp.Close()
+	assert.NoError(t, err)
+}
+
+func TestHTTPPlugin_Admit_WithAllOptions(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		assert.Equal(t, "Bearer mytoken", r.Header.Get("Authorization"))
+		w.WriteHeader(http.StatusOK)
+		w.Write([]byte(`{"ok": true}`))
+	}))
+	defer srv.Close()
+
+	// Test with various plugin options
+	p := &httpPlugin{
+		url:    srv.URL,
+		client: plugin.NewHTTPClient(&plugin.Options{}),
+		header: http.Header{"Authorization": []string{"Bearer mytoken"}},
+	}
+	assert.True(t, p.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+func TestHTTPPlugin_Admit_BadURL(t *testing.T) {
+	// A URL that causes http.NewRequestWithContext to fail.
+	hp := &httpPlugin{
+		url:    "http://invalid hostname", // space causes NewRequest to fail
+		client: plugin.NewHTTPClient(&plugin.Options{}),
+	}
+	assert.False(t, hp.Admit(context.Background(), "tcp", "192.168.1.1"))
+}
+
+var _ io.Closer = (*httpPlugin)(nil)